Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modify worker file path to satisfy the dependency analysis #72

Merged
merged 4 commits into from
Sep 15, 2023
Merged

refactor: modify worker file path to satisfy the dependency analysis #72

merged 4 commits into from
Sep 15, 2023

Conversation

kricsleo
Copy link
Contributor

close #71

AriPerkkio
AriPerkkio requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change should be done to src/runtime/process-worker.ts

@kricsleo
Copy link
Contributor Author

Sorry, my bad, it's been added now :）

AriPerkkio
AriPerkkio reviewed Sep 15, 2023
View reviewed changes
src/runtime/process-worker.ts Outdated Show resolved Hide resolved
src/runtime/thread-worker.ts Outdated Show resolved Hide resolved
@AriPerkkio AriPerkkio changed the title chore: modify worker file path to satisfy the dependency analysis refactor: modify worker file path to satisfy the dependency analysis Sep 15, 2023
Aslemammad
Aslemammad approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Aslemammad Aslemammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aslemammad Aslemammad merged commit f3c1623 into tinylibs:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aslemammad Aslemammad Aslemammad approved these changes

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing worker file after build with nuxt3
3 participants
@kricsleo @AriPerkkio @Aslemammad